Convert MatchOptions to RouteOptions on the fly #4186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the current route response contains a MatchOptions, convert it to a RouteOptions before attempting to update the navigator with it instead of reporting an internal error or, in CarPlay, tripping a precondition failure.
1ec5
added
bug
MaximAlien
approved these changes
Oct 5, 2022
Udumft
approved these changes
Oct 5, 2022
azarovalex
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported a small part of #4127 to the release-v2.8 branch to fix #4126, which is a regression introduced in #3824.
If the current route response contains a MatchOptions, convert it to a RouteOptions before attempting to update the navigator with it instead of reporting an internal error or, in CarPlay, tripping a precondition failure.
/cc @mapbox/navigation-ios