Update to Maps v10.10.0-rc.1, NavNative 122.0.0, Common v23.2.0-rc.3 #4283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShanMa1991
commented
Nov 30, 2022
| @@ -209,7 +209,7 @@ public class MapboxRoutingProvider: RoutingProvider { | |||
| let directionsUri = settings.directions.url(forCalculating: options).removingSKU().absoluteString | |||
| var requestId: RequestId! | |||
|
|
|||
| requestId = router.getRouteForDirectionsUri(directionsUri) { [weak self] (result, origin) in | |||
| requestId = router.getRouteForDirectionsUri(directionsUri, options: GetRouteOptions(timeoutSeconds: nil)) { [weak self] (result, origin) in | |||
There was a problem hiding this comment.
Should we set a default timeout for the route request? @mapbox/navigation-ios
There was a problem hiding this comment.
I think we have 60 seconds timeout in Directions, but since this setting allows a 'default' nil - we should probably use that.
…lternative routes requesting to avoid testReroutingFromALocationSendsEvents crash
kried
reviewed
Nov 30, 2022
kried
reviewed
Nov 30, 2022
kried
approved these changes
Nov 30, 2022
MaximAlien
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pr is to update the dependency to Maps v10.10.0-rc.1, NavNative v122.0.0, Common v23.2.0-rc.3
Implementation
Screenshots or Gifs