NavNative v124.0.1 #4333
Merged
NavNative v124.0.1 #4333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API compatibility report for MapboxCoreNavigation: 🔴Removed Decls
Moved Decls
|
S2Ler
commented
Jan 17, 2023
API compatibility report for MapboxCoreNavigation: 🔴Removed Decls
Moved Decls
|
Codecov Report
@@ Coverage Diff @@
## main #4333 +/- ##
==========================================
+ Coverage 60.59% 60.65% +0.06%
==========================================
Files 189 189
Lines 21115 21115
==========================================
+ Hits 12795 12808 +13
+ Misses 8320 8307 -13
|
S2Ler
force-pushed
the
s2ler/update-dependencies
branch
3 times, most recently
from
d9011e4
to
cd49dcb
Compare
S2Ler
commented
Jan 17, 2023
S2Ler
force-pushed
the
s2ler/update-dependencies
branch
from
cd49dcb
to
ec9431f
Compare
S2Ler
force-pushed
the
s2ler/update-dependencies
branch
from
850d90c
to
aa91a5b
Compare
kried
approved these changes
Jan 17, 2023
NavNative breaking changes in RoadName structure required adaptation on SDK side. As part of this: RoadName and Shield was updated to match native side.
kried
force-pushed
the
s2ler/update-dependencies
branch
from
c17663a
to
1cf9f46
Compare
kried
reviewed
Jan 26, 2023
| @@ -1027,7 +1027,7 @@ open class CarPlayNavigationViewController: UIViewController, BuildingHighlighti | |||
| if let cachedImage = ImageRepository.shared.cachedImageForKey(cacheKey) { | |||
| return cachedImage | |||
| } else { | |||
| guard case let .guidanceView(guidanceViewImageRepresentation, _, _) = guidanceView, | |||
| guard case let .guidanceView(guidanceViewImageRepresentation, _) = guidanceView, | |||
There was a problem hiding this comment.
We rollbacked Directions changes, so we need to rollback it also in SDK
| @@ -56,7 +64,6 @@ | |||
| * Fixed an issue where the route progress could be incorrectly calculated for folding back route steps. ([#4234](https://github.com/mapbox/mapbox-navigation-ios/pull/4234)) | |||
| * `NavigationView.init(frame:tileStoreLocation:navigationMapView:)`, `NavigationView.navigationMapView`, `NavigationView.floatingStackView`, `NavigationView.floatingButtons`, `NavigationView.wayNameView`, `NavigationView.speedLimitView`, `NavigationView.topBannerContainerView` and `NavigationView.bottomBannerContainerView` are now publicly accessible. ([#4249](https://github.com/mapbox/mapbox-navigation-ios/pull/4249)) | |||
| * Fixed an issue where empty intersections of the current step could cause a crash. ([#4260](https://github.com/mapbox/mapbox-navigation-ios/pull/4260)) | |||
| * Fixed an issue where `RouteProgress.currentLegProgress.currentStepProgress.userDistanceToUpcomingIntersection` could be incorrectly calculated for folding back route steps. ([#4268](https://github.com/mapbox/mapbox-navigation-ios/pull/4268)) | |||
There was a problem hiding this comment.
It was not included in 2.10.0, so I moved it to 2.11.0
Udumft
approved these changes
Jan 27, 2023
| /// The shield text. | ||
| public let name: String | ||
|
|
||
| /// The shield text color. |
There was a problem hiding this comment.
We should probably expand how color is described into a string. Is it it's name, hex string or else? Probably event convert to UIColor?
There was a problem hiding this comment.
I asked NavNative. It is just a strong with color name like "white"
There was a problem hiding this comment.
I updated the comment in similar way to Directions
kried
force-pushed
the
s2ler/update-dependencies
branch
from
f0fee88
to
fca548b
Compare
azarovalex
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Android counter-part: mapbox/mapbox-navigation-android#6833
TODO: