Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes following camera bottom padding calculation #4350

Merged
merged 3 commits into from Feb 3, 2023

Conversation

S2Ler
Copy link
Contributor

@S2Ler S2Ler commented Feb 3, 2023

Description

Fixes #3677, NAVIOS-439. Thanks to @dmitry-yashkin for the suggested fix.

Implementation

Screenshots or Gifs

@S2Ler S2Ler self-assigned this Feb 3, 2023
@S2Ler S2Ler requested a review from a team February 3, 2023 06:56
@S2Ler S2Ler marked this pull request as ready for review February 3, 2023 07:01
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #4350 (64b0187) into main (8b68d7e) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4350   +/-   ##
=======================================
  Coverage   60.65%   60.66%           
=======================================
  Files         189      189           
  Lines       21115    21115           
=======================================
+ Hits        12808    12809    +1     
+ Misses       8307     8306    -1     
Impacted Files Coverage Δ
...apboxNavigation/NavigationViewportDataSource.swift 90.71% <66.66%> (+0.21%) ⬆️

Instead of using CarPlay screen, use actual CarPlay map bounds.
@S2Ler
Copy link
Contributor Author

S2Ler commented Feb 3, 2023

CI error is unrelated to the cange

@S2Ler S2Ler merged commit 5882d31 into main Feb 3, 2023
@S2Ler S2Ler deleted the NAVIOS-439-camera-issue branch February 3, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Map is not centered on the user location when the navigation UI is embedded in a small view
3 participants