Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add synchronisation for isInvalidated in RerouteController #4453

Merged
merged 1 commit into from
May 11, 2023
Merged

Add synchronisation for isInvalidated in RerouteController #4453

merged 1 commit into from
May 11, 2023

Conversation

kried
Copy link
Contributor

@kried kried commented May 11, 2023

Description

Add synchronization for isInvalidated in RerouteController

Resolves

@kried there is no guarantee that deinit (where this method is called) will be called on the main thread. It is better to synchronize access to isInvalidated properly.

@kried kried self-assigned this May 11, 2023
@kried kried mentioned this pull request May 11, 2023
Merged
@kried kried mentioned this pull request May 11, 2023
Merged
@kried kried marked this pull request as ready for review May 11, 2023 11:00
@kried kried requested a review from a team as a code owner May 11, 2023 11:00
@github-actions github-actions bot requested a review from Udumft May 11, 2023 11:01
@kried kried merged commit 81cc546 into main May 11, 2023
2 checks passed
@kried kried deleted the NAVIOS-1116-synchronize branch May 11, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S2Ler S2Ler S2Ler approved these changes

@Udumft Udumft Awaiting requested review from Udumft

Assignees

@kried kried

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kried @S2Ler