Use Style for unknown eta color #549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederoni
reviewed
Aug 28, 2017
| @@ -25,6 +27,10 @@ class RouteTableViewController: UIViewController { | |||
| distanceFormatter.numberFormatter.locale = .nationalizedCurrent | |||
| } | |||
|
|
|||
| override func viewDidLoad() { | |||
| defaultTimeRemainingColor = headerView.timeRemaining.textColor | |||
There was a problem hiding this comment.
Not calling super here can result in all kinds of obscure behavior.
|
Closing in favor of a traitCollection style refactor #536 @frederoni |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not properly setting the ETA color according to the style when it was unknown.
@frederoni What do you think of this approach? Any other way we can fix this?
/cc @pveugen