Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traffic Plugin add above road layer #14

Closed
tobrun opened this issue Apr 11, 2017 · 1 comment · Fixed by #61
Closed

Traffic Plugin add above road layer #14

tobrun opened this issue Apr 11, 2017 · 1 comment · Fixed by #61
Labels
bug A bug is found inside the code base and should be immediately brought to attention ASAP

Comments

@tobrun
Copy link
Member

tobrun commented Apr 11, 2017

We added a Traffic Plugin in #6, currently we hardcode the layerId which we use in addLayerBefore(layer, layedId). Ideally we use can use the source layer identifier to check for a road identifier instead.

Upstream feature ticket for source layer identifier in mapbox/mapbox-gl-native#8663
@tobrun tobrun added the bug A bug is found inside the code base and should be immediately brought to attention ASAP label Apr 11, 2017
@tobrun tobrun mentioned this issue Apr 11, 2017
Merged
@tobrun
Copy link
Member Author

tobrun commented Jun 29, 2017

Adding here that we need to use source layer identifier in setVisibility as well.

@cammace cammace mentioned this issue Jul 17, 2017
Merged
@ivan-shen ivan-shen mentioned this issue Nov 2, 2017
Closed
@ericrwolfe ericrwolfe mentioned this issue Nov 21, 2017
Closed
@psinetron psinetron mentioned this issue Mar 6, 2018
Closed
@MArman88 MArman88 mentioned this issue Sep 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug is found inside the code base and should be immediately brought to attention ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Few improvements to traffic plugin mapbox/mapbox-plugins-android
1 participant
@tobrun