Traffic Plugin #6
Conversation
|
@zugaldia I found the remaining issue (not having filters setup). |
There was a problem hiding this comment.
I'll leave the final approval up to @zugaldia, but at a high level everything looks great to me.
Traffic.java looks simple to use by itself and straightforward to customize should someone need to.
Should we update the repo's readme with installation instructions and a short code snippet around usage, or will this get out of hand as we add more plugins? Are there better ways to deal with this on Android?
My suggestion would be to add |
plugins/app/build.gradle
Outdated
| @@ -20,11 +20,19 @@ android { | |||
| } | |||
|
|
|||
| dependencies { | |||
| compile fileTree(dir: 'libs', include: ['*.jar']) | |||
| compile fileTree(include: ['*.jar'], dir: 'libs') | |||
There was a problem hiding this comment.
Is this line necessary at all?
| } | ||
| } | ||
|
|
||
| private boolean requiresLocationPermission(String name, String category) { |
|
|
||
| <!-- Categories --> | ||
| <string name="category">category</string> | ||
| <string name="category_runtime_styling">Runtime Styling</string> |
There was a problem hiding this comment.
Let's call it Navigation in preparation for #12.
| <string name="title_traffic">Traffic Plugin</string> | ||
|
|
||
| <!-- Descriptions --> | ||
| <string name="description_traffic">Add Traffic layer to any Mapbox basemap.</string> |
plugins/traffic/build.gradle
Outdated
| } | ||
|
|
||
| dependencies { | ||
| compile fileTree(dir: 'libs', include: ['*.jar']) |
| } | ||
|
|
||
| /** | ||
| * Initialise the Traffic source and layers |
| LineLayer local = TrafficLayer.getLineLayer(Local.BASE_LAYER_ID, lineColor, otherWidth, otherOffset, Local.ZOOM_LEVEL, Local.FILTER); | ||
| LineLayer localCase = TrafficLayer.getLineLayer(Local.LOCAL_CASE_LAYER_ID, lineColorCase, otherCaseWidth, otherOffset, Local.ZOOM_LEVEL, Local.FILTER); | ||
|
|
||
| // // TODO: add above highest road label instead of bridge-motorway https://github.com/mapbox/mapbox-gl-native/issues/8663 |
| String id; | ||
| for (Layer layer : layers) { | ||
| id = layer.getId(); | ||
| // TODO use sourceLayer filter instead |
| * Use {@link #isEnabled()} to validate if the plugin is active or not. | ||
| * </p> | ||
| */ | ||
| public final class Traffic implements MapView.OnMapChangedListener { |
There was a problem hiding this comment.
Could we call this class TrafficPlugin instead? This could be the only convention for now, all plugins should have the Plugin suffix.
plugins/traffic/build.gradle
Outdated
| minSdkVersion 15 | ||
| targetSdkVersion 25 | ||
| versionCode 1 | ||
| versionName "1.0" |
There was a problem hiding this comment.
Let's start with version 0.1 for now so that we aren't tied to SEMVER.
|
@tobrun Plugin is in great shape, I only added a few minor comments.
Agreed. Let's start with the basics, which is to list all the plugins in the @langsmith will be running point for the next iteration of docs and include them in the website. I'll ticket that separately. |
|
Rebased with master for PR with CI, review comments addressed and ready for review. |
|
Follow up ticket to handle the |
Closes #4