Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped Java SDK to 5.0.0 #1086

Merged
merged 1 commit into from Mar 3, 2020
Merged

Bumped Java SDK to 5.0.0 #1086

merged 1 commit into from Mar 3, 2020

Conversation

langsmith
Copy link
Contributor

@langsmith langsmith requested a review from tobrun January 14, 2020 02:54
@langsmith langsmith self-assigned this Jan 14, 2020
@langsmith langsmith added the ready for review When your PR has been personally reviewed, its time for an external contributors to approve label Jan 14, 2020
@langsmith
Copy link
Contributor Author

👉👉 @tobrun

@tobrun
Copy link
Member

tobrun commented Jan 15, 2020

Rather not introduce androidX in a codebase that doesn't use jetifier and a Maps SDK that is still using support library. Let's hold off merging this until Maps 9.0.0 has been released.

@langsmith
Copy link
Contributor Author

Ok, closing this. Ticketed #1089 as a reminder to eventually bump to at least 5.0.0.

@langsmith
Copy link
Contributor Author

Resolves #1089

@langsmith
Copy link
Contributor Author

I'm going to do manual QA of test app before merging this

@langsmith
Copy link
Contributor Author

Plugins are looking good with manual QA of this repo's test appl

@langsmith langsmith merged commit 4465665 into master Mar 3, 2020
@langsmith langsmith deleted the ls-java-sdk-5.0.0-bump branch March 3, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ DO NOT MERGE ready for review When your PR has been personally reviewed, its time for an external contributors to approve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants