Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maps SDK bump to 6.4.0 #615

Merged
merged 2 commits into from
Aug 20, 2018
Merged

Maps SDK bump to 6.4.0 #615

merged 2 commits into from
Aug 20, 2018

Conversation

langsmith
Copy link
Contributor

Part of the Maps SDK 6.4.0 release

@langsmith
Copy link
Contributor Author

@danesfeder @LukasPaczos @tobrun

Something weird is going on with this bump and Firebase 🤔 . I've re-run the tests in CircleCI a couple of times, but it doesn't help. Have you seen this issue recently with prs in this repo?

@LukasPaczos
Copy link
Member

The issue is that the source is null and we are timing out. This behavior first appears with the 6.4.0-beta.1.

@LukasPaczos
Copy link
Member

Taking above back, it's actually the query that returns an empty list.

@langsmith
Copy link
Contributor Author

Any next steps?

@LukasPaczos
Copy link
Member

f648409 adjusts for a change that was introduced in mapbox/mapbox-gl-native#12529 which resulted in sources that are barely out of the camera view not being pre-fetched anymore, and since we have a minimum zoom level of 2, the edge of the last tile is out of view and we have no data about a feature that was set to POSITIVE_INFINITY in #516, that's why the query linked above was always returning an empty collection.

f648409 hides the layer instead, until the first location update is provided.

@danesfeder would you mind 👀 this PR as well?

@danesfeder danesfeder self-requested a review August 20, 2018 13:34
Copy link
Contributor

@danesfeder danesfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spoke with @LukasPaczos about #615 (comment) and sounds like some solid improvements to the lifecycle logic. Also tested locally and everything looked 💯. Thanks for the work and debugging on the @langsmith @LukasPaczos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants