Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uploads #26

Merged
merged 8 commits into from
Jul 30, 2015
Merged

Add uploads #26

merged 8 commits into from
Jul 30, 2015

Conversation

willwhite
Copy link
Contributor

Adds support for the uploads api.

@willwhite willwhite force-pushed the uploads branch 5 times, most recently from 33c30c4 to 952f12d Compare July 30, 2015 01:20
@tmcw
Copy link
Contributor

tmcw commented Jul 30, 2015

How do you feel about the S3 part of this? Should mapbox-sdk-js require aws-sdk and manage this for you, or should we just provide code samples that demonstrate integration?

@willwhite
Copy link
Contributor Author

I'm learning towards keeping this a very light wrapper around the HTTP API (and small dependency tree especially for the browser). It seems like something higher level that could be added later or by another project. That said, I could be convinced either way.

@rclark
Copy link
Contributor

rclark commented Jul 30, 2015

keeping this a very light wrapper around the HTTP API

👍 IMO this SDK should provide the base-level building blocks and let service-specific tools handle higher-level niceties where needed.

@tmcw
Copy link
Contributor

tmcw commented Jul 30, 2015

Yep, agree. The aws-sdk is also a very heavy dependency and not all users are going to use uploads.

willwhite added a commit that referenced this pull request Jul 30, 2015
@willwhite willwhite merged commit bfb2de9 into master Jul 30, 2015
@willwhite willwhite deleted the uploads branch July 30, 2015 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants