-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uploads #26
Add uploads #26
Conversation
33c30c4
to
952f12d
Compare
How do you feel about the S3 part of this? Should mapbox-sdk-js require aws-sdk and manage this for you, or should we just provide code samples that demonstrate integration? |
I'm learning towards keeping this a very light wrapper around the HTTP API (and small dependency tree especially for the browser). It seems like something higher level that could be added later or by another project. That said, I could be convinced either way. |
👍 IMO this SDK should provide the base-level building blocks and let service-specific tools handle higher-level niceties where needed. |
Yep, agree. The aws-sdk is also a very heavy dependency and not all users are going to use uploads. |
Better way of handling this in: #27
Adds support for the uploads api.