Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing staging to cloudfront-staging #172

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Changing staging to cloudfront-staging #172

merged 1 commit into from
Dec 15, 2023

Conversation

ahmedaly16
Copy link
Contributor

Description

Fixes this: https://mapbox.atlassian.net/browse/SSDK-332

Screenshots or Gifs

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR (where applicable)
  • I have run tests and automatic checks locally
  • I have run pitest check locally and checked that the coverage increased (or didn't change) or decreased insignificantly
  • I have made corresponding changes to the documentation (where applicable)
  • I have grouped commits logically or I promise to squash my commits before merge

@ahmedaly16 ahmedaly16 requested review from a team as code owners December 14, 2023 17:27
@ahmedaly16 ahmedaly16 merged commit cf2a332 into main Dec 15, 2023
6 of 7 checks passed
@ahmedaly16 ahmedaly16 deleted the aaly-staging branch December 15, 2023 11:22
@mapbox-github-ci-issues-3 mapbox-github-ci-issues-3 bot mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DzmitryFomchyn DzmitryFomchyn DzmitryFomchyn approved these changes

@4rtzel 4rtzel Awaiting requested review from 4rtzel 4rtzel is a code owner automatically assigned from mapbox/search-sdk

@mapbox-danny mapbox-danny Awaiting requested review from mapbox-danny mapbox-danny is a code owner automatically assigned from mapbox/search-sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahmedaly16 @DzmitryFomchyn