Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no zooming on slippy map example #54

Closed
AndrewIK opened this issue May 7, 2017 · 5 comments
Closed

no zooming on slippy map example #54

AndrewIK opened this issue May 7, 2017 · 5 comments
Labels

Comments

@AndrewIK
Copy link

AndrewIK commented May 7, 2017

I've tried to hack it with a _mapController.Execute call from Slippy.cs : Update() and it partially worked but there were a lot of
MissingReferenceException: The object of type 'UnityTile' has been destroyed but you are still trying to access it.
here and there. I can band-aid it with != null check but I'm afraid it will only mask the actual problem.

If implementing zoom for slippy map is not on the near future roadmap, can you please advise on the right approach to it?

Thank you!

@david-rhodes
Copy link

@AndrewIK

If implementing zoom for slippy map is not on the near future roadmap, can you please advise on the right approach to it?

Thanks for writing the ticket! First of all, a better slippy implementation (including dynamic zoom) is on our roadmap. Currently, though, your best bet to to ensure you reinitialize the factories (as seen in MapController.cs). This will clear the internal tile dictionaries. We'll probably add an Unregister(UnityTile tile) method to Factory.cs to help clean up some of these errors that pop up (remove dependencies of tiles that need to be destroyed or pooled).

We're working on it, but I hope this is enough information to help in the meantime.

@AndrewIK
Copy link
Author

AndrewIK commented May 9, 2017

thanks for the directions, I'll close it now

@AndrewIK AndrewIK closed this as completed May 9, 2017
@david-rhodes
Copy link

@AndrewIK you may want to look at #74. There are several performance and architecture improvements. We have not yet implemented zooming, but tiles have a cancel hook now, and the factories should respect that. We will try to add zooming soon!

@mrgithub
Copy link

+1 for this feature. Any idea when this will be released?

@david-rhodes
Copy link

@mrgithub This is already in the SDK in a few forms. You can now reinitialize a map component with a different location and zoom level. Additionally, we have a DynamicZoomMap which operates much like a basic web map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants