This repository has been archived by the owner on Apr 24, 2024. It is now read-only.
correct overzooming bug when maxZoom options are specified by user #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: tvblomberg <tvblomberg@users.noreply.github.com>
|
Checking with the manual test, the patch does not appear to resolve the erroneous behavior.
So this one actually requires more digging, and as a result I'm going to descope it from the v3.3.0 release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1250
Back in 2018, @tvblomberg put up a PR that solved an overzooming bug (ref. #1251).
The bug fix is sound, but enough time has passed that I think pulling these changes into a new PR and testing them against the current state of the repo. I also want to add a manual test that can be used to quickly determine if this has regressed.