Fix Match function type default circle radius bug (#74)

* fixed default radius coerce to string bug, add test * updated example to include match type radius function
mapbox · Mar 17, 2018 · 5ca5cbd · 5ca5cbd
1 parent fcea62b
commit 5ca5cbd
Show file tree

Hide file tree

Showing 3 changed files with 358 additions and 39 deletions.
diff --git a/examples/point-viz-categorical-example.ipynb b/examples/point-viz-categorical-example.ipynb
diff --git a/mapboxgl/templates/graduated_circle.html b/mapboxgl/templates/graduated_circle.html
@@ -63,7 +63,7 @@
         "minzoom": {{ minzoom }},
         "paint": {
             "circle-color": generatePropertyExpression("{{ colorType }}", "{{ colorProperty }}", {{ colorStops }}, "{{ defaultColor }}" ),
-            "circle-radius" : generatePropertyExpression("{{ radiusType }}", "{{ radiusProperty }}", {{ radiusStops }}, "{{ defaultRadius }}" ),
+            "circle-radius" : generatePropertyExpression("{{ radiusType }}", "{{ radiusProperty }}", {{ radiusStops }}, {{ defaultRadius }} ),
             "circle-stroke-color": "grey",
             "circle-stroke-width": generatePropertyExpression('interpolate','zoom', [[0,0.01], [18,1]]),
             "circle-opacity" : {{ opacity }}

diff --git a/tests/test_html.py b/tests/test_html.py
@@ -89,6 +89,10 @@ def test_display_GraduatedCircleViz(display, data):
                              color_property="Avg Medicare Payments",
                              label_property="Avg Medicare Payments",
                              radius_property="Avg Covered Charges",
+                             radius_function_type="match",
+                             color_function_type="match",
+                             radius_default=2,
+                             color_default="red",
                              access_token=TOKEN)
     viz.show()
     display.assert_called_once()