Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RasterTilesViz #63

Merged
merged 5 commits into from
Mar 17, 2018
Merged

add RasterTilesViz #63

merged 5 commits into from
Mar 17, 2018

Conversation

vincentsarago
Copy link
Collaborator

This PR adds a simple raster-tiles visualization.

capture d ecran 2018-03-08 a 10 09 44

@akacarlyann
Copy link
Collaborator

Sweet! I'd really been hoping someone would hit this :)

Copy link
Contributor

@ryanbaumann ryanbaumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @vincentsarago. Merge when you're ready!

@ryanbaumann ryanbaumann mentioned this pull request Mar 11, 2018
@vincentsarago
Copy link
Collaborator Author

@ryanbaumann I did some edits + added docs.
you can have an other 👀 and merge it if it's 👌

@@ -27,7 +27,7 @@
document.getElementById('legend').style.visibility = 'hidden';

map.on('style.load', function() {

console.log('Yoooooo');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could remove this line ;)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups!

@vincentsarago
Copy link
Collaborator Author

@ryanbaumann matplotlib is a preste standard library when working with Jupyter and image data. we don't just use imread but also imsave. I'm eager to keep it as it is, plus it makes really easy to apply colormap.

@ryanbaumann
Copy link
Contributor

Thanks, @vincentsarago. Agree, most always have matplotlib installed from prior work or via Anaconda as is.

@ryanbaumann ryanbaumann merged commit dc0af95 into master Mar 17, 2018
@ryanbaumann ryanbaumann mentioned this pull request Mar 25, 2018
@vincentsarago vincentsarago deleted the RasterTilesViz branch June 27, 2018 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants