Refactor HTML templates to use Jinja template inheritance for initial… #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ization of map, navigation control, etc.
ryanbaumann
approved these changes
Mar 29, 2018
|
Great organization @akacarlyann. Thanks for refactoring. This will make it easier to support multiple viz layers in the next release too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ization of map, navigation control, etc. Rename base.html to map.html for consistency with MapViz --> template naming scheme. Adds new base.html file for template inheritance. This file contains the map initialization. Simple refactor meant to decrease number of files to change for global updates to all viz types.