Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3-d option for choropleth extrusion; support pitch and bearing arguments for MapViz #90

Merged
merged 5 commits into from
Apr 17, 2018

Conversation

akacarlyann
Copy link
Collaborator

@akacarlyann akacarlyann commented Apr 1, 2018

Addresses #4, #15; closes #83

@akacarlyann akacarlyann force-pushed the choropleth-extrude branch 2 times, most recently from a46358b to b11698d Compare April 1, 2018 01:43
@ryanbaumann
Copy link
Contributor

ryanbaumann commented Apr 1, 2018

Hehe, this is awesome @akacarlyann. Nice work!

Notes:

  • Tooltips: if the same measure is used for both height and color, do not put the same property in the tooltip twice.
  • Legend: if a different measure is used for color and height, we should mention the measure in the legend and indicate what color vs. height represents.

Unrelated note on performance:

@ryanbaumann
Copy link
Contributor

@akacarlyann no rush here yet, but wondering if you've had a chance for to take a pass on any of the feedback above or are ready for a final PR review.

@akacarlyann
Copy link
Collaborator Author

@ryanbaumann funny timing - I'm heading to the coffee shop to work on this today! It's my first chance in a couple weeks. For the SF population graphic, there is an updating scale 3d height in the legend. Is there any public source code you can think of that might implement something similar? Otherwise I'll just handle it similarly to the way we do color v radius for the graduated circle viz.

@ryanbaumann
Copy link
Contributor

@akacarlyann the legend in www.mapbox.com/bites/00273 is pretty custom CSS and HTML - I'd have to search around to see if there are any modularized components for size extruded / 3D data visualizations

…roperty; add note to legend title if two properties used for data-driven styling
@akacarlyann
Copy link
Collaborator Author

@ryanbaumann Got it. Removed duplicate add to tooltip if height_property equals color_property and added note to legend title if height based on different property from color. Ready for you to take a look.

@ryanbaumann
Copy link
Contributor

Nice work @akacarlyann. A few updates to tests for coverage of the new utils function height_map and I think we're ready to merge.

@ryanbaumann ryanbaumann merged commit 41a9cc3 into mapbox:master Apr 17, 2018
Copy link

@lucasvw lucasvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi guys, really cool feature! One thing though, you currently dont check the height_default parameter to set self.extrude to true.

@ryanbaumann
Copy link
Contributor

Thanks @lucasvw - could you open a quick issue ticket or PR for the change or bug? This PR is old. Thank you!

@akacarlyann akacarlyann deleted the choropleth-extrude branch December 2, 2019 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 3D height option to ChoroplethViz
3 participants