CSV error message handling #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling de39b21 on shortererror into ** on master**. |
|
Changes Unknown when pulling d684f71 on shortererror into ** on master**. |
3 tasks
mapsam
added a commit
that referenced
this pull request
Mar 24, 2017
…ed deps (#165) * update deps * redefine fileinfo.type * CSV error message handling (#161) * add test for bad header csv * add try catch around new mapnik.Datasource * add fixture with empty header column * add substr to shorten message * add try/catch statement * add slice to truncate error message * add tests for empty and wrong headers * add fixture with empty header column * add fixture without detectable headers * add valid csv fixture * return nice error for csv column headers * semicolon * Feature-specific zoom calculations (#163) * start calculating latitude and longitude deltas between source and vector tile * start calculating more data-specific zoom levels * set smallest max zoom for point files * constants * stick with z10 for now * update expected zooms * update sm version * update appveyor node versions * pin node versions * update changelog [skip ci] * no more error slicing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tandem with error message revisions made in Mapnik: mapnik/mapnik@7c6f335,
This PR's objectives are to: