Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data team peer review 4/18-4/22 #176

Closed
geochetan opened this issue Apr 27, 2016 · 7 comments
Closed

Data team peer review 4/18-4/22 #176

geochetan opened this issue Apr 27, 2016 · 7 comments
Assignees

Comments

@geochetan
Copy link

Starting this week, @mapbox/team-data will open our peer review process to the public (see background information in this diary post). Anyone from the OSM community can review and comment on our edits.

Mapping projects to be reviewed

  1. Exit and Destination Mapping.
  2. To-fix: Unconnected minor highways
  3. To-fix: Overlapping major highways

Instructions

  • Download .osm files for last week.
  • Select any date and extract the files.
  • Each team member will have an osm file of edits during the respective date, for example: 2016-04-20-andygol.osm. Select any .osm file and open the data in JOSM.
  • If no edits were done during that day, JOSM will notify that no data was exist, load another file.

screen shot 2016-04-25 at 6 08 07 pm

  • Examine user edits in detail. In JOSM, select a random small area edited by the user and press 3 to zoom.
  • Download the latest data in OSM as a new layer and add a filter Cmd + F to see only the user's edits, e.g. user:andygol.

andyfilter3

  • Select a way/node and load the the history (Ctrl + H), the changeset comment will describe what specific project the user was working on.
  • To get an OSM link to the object, click Cmd + Shift + H.
  • Note down any feedback for each user in this ticket or comment directly in the changeset. Use this format:
username
changeset link - issue to fix
  • @karitotp or @chtnha will post the feedback in the ticket (Use Github handle because OSM name is different from Github name) and make necessary changes on the same day.
  • Close the ticket once user's have fixed their edits.

For clarifications, discuss with the @mapbox/team-data in this ticket.

@geochetan geochetan self-assigned this Apr 27, 2016
@geochetan
Copy link
Author

@dannykath

Changing highway tag from living_street to residential would be better

@geochetan
Copy link
Author

@geochetan
Copy link
Author

@planemad

Waterway is passing inside the village. Reshaping is necessary

https://www.openstreetmap.org/way/411758585/history

@planemad
Copy link
Contributor

@ediyes
Copy link

ediyes commented Apr 27, 2016

Thnks @chtnha fixed here: https://www.openstreetmap.org/way/414001371/history

@dannykath
Copy link

Thanks @chtnha, fixed https://www.openstreetmap.org/changeset/38938149

@geochetan
Copy link
Author

We had a great peer-review 🎉 No actions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants