Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding turn restrictions in Canada using Mapillary #213

Closed
poornibadrinath opened this issue Jul 20, 2016 · 42 comments
Closed

Adding turn restrictions in Canada using Mapillary #213

poornibadrinath opened this issue Jul 20, 2016 · 42 comments
Assignees
Labels

Comments

@poornibadrinath
Copy link
Contributor

poornibadrinath commented Jul 20, 2016

Goal

  • Mapping turn-restrictions in top 5 Canadian cities using Mapillary as the source
  • Cities: Ottawa, Toronto, Montréal, Vancouver, Calgary

Task Workflow

  1. Using the OSM navigation map
  2. Mapping turn restrictions from Mapillary
  3. Progress spreadsheet

Team : @mapbox/team-data

Timeline : 1 week (Estimate)

Tagging guidelines

Data sources

  • Mapillary detected traffic signs via OSM navigation map and JOSM plugin
  • Bing/Mapbox satellite imagery for cross verification of photograph location/bearing and turn lane markings

Process

  • Two mappers can work on one city together and update the spreadsheet with their names, start and end time
  • Divide the city into half based on a road/landmark and work at different parts of the city to avoid conflict
  • The number of already mapped turn restrictions is given in the spreadsheet. Use the Overpass queries given in the spreadsheet to get the edit count after a city is completed

JOSM Setup

Changeset Comment:
Updating turn restrictions in CITYNAME using Mapillary imagery https://github.com/mapbox/mapping/issues/213

Source: Bing/Mapillary


Daily Stats:

Date City Reviewed Before After Added Turn Restrictions*
21 July 2016 Ottawa 111 450 476 26
25 July 2016 Ottawa 229 476 489 13
Toronto 1129 1140 11
Vancouver 441 471 30
Montreal 372 385 13
Calgary 64 73 9
26 July 2016 Ottawa 138 489 503 14
Toronto 1140 1148 8
Vancouver 471 477 6
Montreal 385 409 24
27 July 2016 Ottawa 118 503 521 18
Toronto 1148 1160 12
Vancouver 477 488 11
Montreal 409 424 15
28 July 2016 Ottawa 166 521 548 17
Toronto 1160 1166 6
Vancouver 488 488 0
Montreal 424 428 4
01 August 2016 Ottawa 230 548 571 23
Toronto 1166 1206 40
Vancouver 488 510 22
Montreal 428 430 2
02 August 2016 Ottawa 348 571 616 45
Toronto 1206 1222 16
Vancouver 510 557 47
03 August 2016 Ottawa 262 616 642 26
Toronto 1222 1247 25
Vancouver 557 561 4
04 August 2016 Toronto 393 1247 1293 46
05 August 2016 Toronto 393 1293 1332 49
Total 582 *
  • Note: The number of added turn turn restrictions includes modified(all versions) turn restrictions as well along with the newly mapped.
@manoharuss manoharuss self-assigned this Jul 20, 2016
@geohacker
Copy link

🚗 🍁

@krishnanammala
Copy link
Contributor

I came across this issue where the mapillary signage showing no_u_turn and it should be added via way instead of node. For this cases we should work in JOSM to add this kind of restrictions. It would be nice to have this feature in iD as well.

screen shot 2016-07-21 at 3 18 44 pm

cc @planemad @bhousel

@planemad
Copy link
Contributor

planemad commented Jul 21, 2016

Came across this sign which I interpreted as no left turn on red or no free left. This is not a turn restriction. Mark as invalid.

screenshot 2016-07-20 17 37 58

@poornibadrinath
Copy link
Contributor Author

Mapillary has an efficient tool in iD that displays the restriction detected.
image
It will help in filtering out the mapillary image with the restriction in iD editor and also know which restriction has been detected.

Here's how activate the tool:
traffic overlay mapillary

@bhousel
Copy link

bhousel commented Jul 21, 2016

For this cases we should work in JOSM to add this kind of restrictions. It would be nice to have this feature in iD as well.

Yes, having turn restrictions via way in iD would be really useful.. We have an issue for it:
openstreetmap/iD#2346

@manoharuss
Copy link
Contributor

Trial run for Ottawa using iD

Summary

What worked well

  • Good Mapillary coverage for Ottawa. Most detected restrictions were already on OSM.
  • Mapillary data layer in iD is very helpful to identify restrictions detected in specific mapillary images.

Pain points

  • iD editor does not support adding no_u_turn restriction via way instead of node. Need to use JOSM for this.
  • Adding conditional restrictions in iD requires editing the tags manually, just like JOSM.
  • It is not possible to see the capture date of the mapillary image in both the Navigation map and iD editor in cases when more than one mapillary path exist on the road. JOSM conquers here.
  • Mapping in iD editor along with the Navigation map requires switching between 3 tabs to map, 2 tabs to see the full image to orient to the location, where as with JOSM it is all baked in when opened from the Navigation map.

Other observations

  • Sudden increase in detected restrictions in the evening corresponding with new Mapillary website launch.

cc @planemad @maning

@ramyaragupathy
Copy link
Contributor

Since mapillary turn restrictions layer is not loading/taking a long time to load in my browser, I'm sticking to iD editor to find out mapillary turn restrictions. Also while doing this, I'm using the gpx of the boundary file so that I don't get lost outside the city boundary.
image

@srividyacb
Copy link
Contributor

Conditional turn-restriction written in French:
These board means Monday-Friday. Source for translation in case anyone sees any other days of the week written in French.

image

@srividyacb
Copy link
Contributor

srividyacb commented Jul 25, 2016

Instructions in french above the turn-restriction sign: 💭

image

@srividyacb
Copy link
Contributor

What are the usual instructions below turn-restrictions like these? The maximum words we can predict on the board is Except Vehicles ?

image

@ghost
Copy link

ghost commented Jul 25, 2016

"Attendre la flèche pour virer à gauche" is not a turn restriction. It warns drivers who turn left to wait for their light with an arrow to appear green
The "Excepté véhicules autorisés" sign means the u-turn restriction doesn't apply to explicitly authorized vehicules.

@scruss
Copy link

scruss commented Jul 25, 2016

You've got that Quebec is all no right turn on red, yes?

@ghost
Copy link

ghost commented Jul 25, 2016

Québec is NOT all no right turn on red. Only Montréal island is.

@srividyacb
Copy link
Contributor

srividyacb commented Jul 26, 2016

Is this turn-lanes or turn-restriction with condition for weekdays? (Link to full size image)

image
(This is the best image of this sign board)

Found another similar image with green circle and weekdays condition written on it. (Full size image)
image

cc @scruss @Peuc

@bsrinivasa
Copy link

bsrinivasa commented Jul 26, 2016

Encountered this case while mapping turn-restrictions at Vancouver. There are a set of detected images of a junction from Mapillary which have been geo located at regular intervals (spacing) for a longer span and has no effect on the image frame with respect to distance. All images represent the same junction at various time intervals. Here are few screenshots to depict the above case.

Link for the map: http://mapbox.github.io/osm-navigation-map/#17.08/49.21491/-122.93419

screen shot 2016-07-25 at 4 53 50 pm copy

screen shot 2016-07-25 at 4 54 06 pm

screen shot 2016-07-25 at 4 54 28 pm

@maanyaumashaanker
Copy link

screen shot 2016-07-26 at 1 12 25 pm

there seems to be an offset in the mapillary restriction as represented in the above image. The point in blue actually corresponds to the TR before it(the green one). This offset could lead to adding wrong turn restrictions. (In this case a no right turn from Sheppard Avenue to Grand Marshall drive but on inspecting the mapillary image closely that is not the case). It would be great if it could be fixed.

@oini
Copy link

oini commented Jul 26, 2016

While adding turn restrictions in Ottawa came across the following issues where I'd appreciate some feedback as to what would be the ideal way to address them.

  • Unnecessarily complicated tracing of roads and junctions

image

The secondary link here is unnecessary as there is no physical divider between the secondary road and the link. This looks like a normal oneway secondary road with 4 lanes and the junction could be just one small bi-directional link. Is it okay to clear such areas up and re-trace the roads?

  • Logically Invalid Turn Restrictions

image

The no-straight-on turn restriction added here seems logically inaccurate as this is resulting in OSRM to compute the below route. Note that this route is in fact inaccurate since there is a 'no-left-turn' restriction from south-bound Woodroffe Avenue to the service road.

image

Also, none of the Mapillary images in that junction account for this turn restriction. I have left a changeset comment requesting confirmation.

cc @planemad @maning

@ghost
Copy link

ghost commented Jul 26, 2016

@srividyacb : Arrow with green circle means all drivers (no matter the line they are on) must follow this/these direction(s) at the intersection. The text at the bottom gives the application time frame.

The first sign says all drivers coming from "54ème Rue" must turn right on "Boulevard Pie IX" from monday to friday (readable) in the given (unreadable) time frames.

The second sign means all drivers from "51ème Rue" must turn right on "Boulevard Pie IX" from monday to friday (readable) in the given (unreadable) time frames.

By the way, it seems there is a rather important offset in the geolocation of the Mapillary images.

@srividyacb
Copy link
Contributor

srividyacb commented Jul 26, 2016

Thank you @Peuc for confirmation. 😄

So turns like this with green circle means only-direction-turns (only-right-turn/only-left-turn) 👍. We are updating things like this in our wiki for future reference.

cc @jinalfoflia @planemad @mapbox/india-office

@poornibadrinath
Copy link
Contributor Author

poornibadrinath commented Jul 26, 2016

Out of the five cities we targeted, we have completed Calgary and the other four cities are work in progress. Daily stats are being updated in the OP.

/cc: @mapbox/team-data

@james2432
Copy link

@oini Seems someone that is inexperienced edited the Carling/Woodruff intersection. That part of town has a lot of invalid things like that and need to be corrected

@oini
Copy link

oini commented Jul 28, 2016

Any idea what this turn restriction implies?

image

@Bootprint1
Copy link

Bootprint1 commented Jul 28, 2016

Baseline is a road in Ottawa. What is the intersection with this sign?
edit:
This looks like the intersection at Merivale Road and Baseline Road, so no lefts from Merivale to Baseline going north-ish.

@james2432
Copy link

@oini No left turns at baseline road (I imagine its the next intersection)

@oini
Copy link

oini commented Jul 28, 2016

Oh, right! Thank you so much @Bootprint1 and @james2432

@poornibadrinath
Copy link
Contributor Author

poornibadrinath commented Jul 28, 2016

Task update: Calgary and Montreal are completed 🎉 💥 . Targeting to finish Toronto, Vancouver and Ottawa in the coming week. Stats are being updated in the OP.

@srividyacb
Copy link
Contributor

Is this turn-restriction saying no-right-turn On Red ? Full size image

image

@andrewpmk
Copy link

This is "No Right Turn at Camosun" (I presume that Camosun is the name of a road).

@srividyacb
Copy link
Contributor

@andrewpmk Yeah right. Seeing Camosun Street joining the main highway. Adding turn-restriction to it. Thank you very much.

@poornibadrinath
Copy link
Contributor Author

image
So this no left restriction board is placed on Dundas Street.

screenshot 2016-08-02 18 36 52

Just wanted to confirm whether this restriction is for no left from Dundas Street to Beamish street (because Beamish Street is on the right side) or is it for Beamish Street to Dundas Street, or for Bloor to Beamish street since all three are different streets.

This is the restriction point that is detected.

@james2432
Copy link

I think they are warning ppl they cant cut through beamish if they want to turn left on bloor street, because you cant turn left on beamish and bloor, you can only turn right

@krishnanammala
Copy link
Contributor

Any Idea on what this Turn Restriction implies?

screen shot 2016-08-02 at 6 48 13 pm

@james2432
Copy link

You must turn right(except bicycles)

@poornibadrinath
Copy link
Contributor Author

@james2432, so this restriction is for Bloor Street from Beamish Street?

@james2432
Copy link

Would seem so I interpret it as people often try taking beamish street to turn left on bloor, but can't and get pissed off. This sign seems to be a warning that there are only right turns at beamish and bloor. So if people want to do so continue on dundas for a street that will allow it

@poornibadrinath
Copy link
Contributor Author

@james2432 Thank you so much for the help! Will add the restriction.

@poornibadrinath
Copy link
Contributor Author

poornibadrinath commented Aug 4, 2016

Turn restriction task update: Out of the five cities, we only have Toronto left to finish adding turn restrictions. The other four cities: Montreal, Vancouver, Calgary and Ottawa are completed 🎉 The stats are being updated in the OP

@CloCkWeRX
Copy link

One plugin for JOSM that may help highlight areas of interest is the improve-osm tools. Combined with mapillary photos, it would likely call out areas where road signs may not have been detected, but traffic patterns suggest there is a restriction.

See http://www.openstreetmap.org/user/mvexel/diary/37571 for a bit more detail.

@poornibadrinath
Copy link
Contributor Author

Turn restriction task update: Adding turn restrictions in five priority cities of Canada (Toronto, Ottawa, Montreal, Vancouver, Calgary) is now complete! 🎉 We are now validating the turn restrictions we added during the sprint. Stats are updated in the OP

@shvrm
Copy link

shvrm commented Aug 9, 2016

@gundersen - We added a total of 364 turn restrictions, and modified/improved 29 turn-restrictions as a team. Between the community and us, we contributed a total of 423 turn restrictions in five cities in Canada.

Here is a detailed breakdown.

Table 1: Breakdown of turn restrictions between Mapbox and Community

City Turn restrictions Version 1(Newly added) Modified/improved (Version 2)
Toronto Mapbox : 90 ; Community : 18 Mapbox : 5 ; Community : 12
Ottawa Mapbox : 94 ; Community : 3 Mapbox : 6 ; Community : 1
Montreal Mapbox : 95 ; Community : 38 Mapbox : 9 ; Community : 7
Vancouver Mapbox : 83 ; Community : 0 Mapbox : 8 ; Community : 1
Calgary Mapbox : 2 ; Community : 0 Mapbox : 1 ; Community : 2
Total Mapbox : 364 ; Community : 59 Mapbox : 29 ; Community : 21

Note: Version 2 is when we modify/improve already existing mapped turn restrictions.

Table 2: Total brand new turn restrictions created during the project (No version 2)

City Total adding during this project both by community and Mapbox
Toronto 108
Ottawa 97
Montreal 133
Vancouver 83
Calgary 2
Total 423

cc: @manoharuss

@poornibadrinath
Copy link
Contributor Author

Adding turn restrictions in Canada is completed in all priority cities. The team and community together have added 423 turn restrictions. 👏 🎉 The stats for individual cities are:

City Total adding during this project both by community and Mapbox
Toronto 108
Ottawa 97
Montreal 133
Vancouver 83
Calgary 2
Total 423

Detailed stats for all the turn restrictions we added can be found here

Also, we have completed validating all the turn restrictions added in five cities. It would be helpful to have the community look into our edits and let us know if there are any errors that we could rectify. There is a neat tool, restriction validator, which shows all the restrictions added, highlighting which ones are incorrect/correct.

It was great to have the community working alongside us in adding turn restrictions, clearing doubts, improving our workflow and suggesting better ways to add restrictions in Canada. We hope the support would continue in our next task of adding exits and destinations for all the major highways in the five priority cities of Canada.

/cc: @mapbox/team-data

@poornibadrinath
Copy link
Contributor Author

Closing #213 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests