Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unbound var in or-tools script #407

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Conversation

daniel-j-h
Copy link
Contributor

Downstream builds are failing because of bash unbound var errors.

Not sure when exactly this changed, all I could find in the changelog is

Fixed
    Unbound variables in sparsehash, bzip2, and harfbuzz packages

Can we automatically check all packages?

cc @springmeyer

@springmeyer
Copy link
Contributor

Not sure when exactly this changed, all I could find in the changelog is

This started throwing in the v0.8.0 release per mason now run with set -u to catch undefined variables in scripts (#356) https://github.com/mapbox/mason/blob/master/CHANGELOG.md#080.

Can we automatically check all packages?

Kicked off this work at #408

@springmeyer
Copy link
Contributor

Downstream builds are failing because of bash unbound var errors.

Note: in the future we plan to finish the lightweight client (#396), such that all downstream installers of packages will only depend on the mason.ini and therefore be isolated from any breakages in the script.sh which will only be used for builds.

@springmeyer
Copy link
Contributor

Thanks for finding and fixing this bug @daniel-j-h - will merge now. This will go out in the upcoming v0.10.0 release.

@springmeyer springmeyer merged commit 5acc06b into master Apr 12, 2017
@springmeyer springmeyer deleted the or-tools-unbound-var branch April 12, 2017 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants