Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Feature Properties in Popup #55

Merged
merged 1 commit into from
Jan 13, 2017
Merged

Show Feature Properties in Popup #55

merged 1 commit into from
Jan 13, 2017

Conversation

lukasmartinelli
Copy link
Contributor

Hey @aaronlidman :)

Feel free to use or throw away.
This resolves #47. It shows a popup with all features and their properties when hovering over the map.

The query box code was originally written by @tcql in lukasmartinelli/mapbox-gl-inspect#3. Rest is adapted from the https://github.com/lukasmartinelli/mapbox-gl-inspect plugin.

screenshot from 2017-01-13 00-22-42

@aaronlidman
Copy link
Contributor

Tim just talking about adding this yesterday, one step ahead of us Lukas. This looks and works great! Thanks!

@aaronlidman aaronlidman merged commit ba8e5c2 into mapbox:master Jan 13, 2017
@tcql
Copy link
Contributor

tcql commented Jan 13, 2017

In the future, I'd like it if we used browserify or some other build system so we can just include the actual mapbox-gl-inspect plugin (and make it easier to get updates & fixes) instead of copy+pasting its functionality in

@lukasmartinelli
Copy link
Contributor Author

In the future, I'd like it if we used browserify or some other build system so we can just include the actual mapbox-gl-inspect plugin (and make it easier to get updates & fixes) instead of copy+pasting its functionality in

Yes you're right. This was just the less obtrusive option to start with. Thanks you two.

@defvol
Copy link
Contributor

defvol commented Jan 13, 2017

great work @lukasmartinelli!

@tcql
Copy link
Contributor

tcql commented Jan 13, 2017

I created #56 to track future work towards bundling the plugin. Thanks for the contribution @lukasmartinelli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show properties
4 participants