issue#9 - print updated dates #10
Conversation
There was a problem hiding this comment.
Thanks for this @mohit2agrawal. It's really close. A few small changes and we can merge
bin/cli.js
Outdated
| issues | ||
| .sort((a, b) => { | ||
| if (a.repo === b.repo) return a.id - b.id; | ||
| if (a.repo === b.repo){ | ||
| if (a.updated_at === b.updated_at) |
There was a problem hiding this comment.
the name of the variable is updated
bin/cli.js
Outdated
| lastDate = null; | ||
| } | ||
| if (lastDate !== iss.updated_at){ | ||
| console.log(`\n**${iss.updated_at}**\n`); // eslint-disable-line no-console |
There was a problem hiding this comment.
Currently this prints out undefined as the variable is updated rather than updated_at
|
Hi @mcwhittemore, I have made the changes. |
There was a problem hiding this comment.
Mohit,
Sorry. One more thing. This currently adds date and time rather than just date. This means that most issues will have their own header that looks something like **2017-09-12T00:59:34Z**. The linked ticketed requested the date so this should look something like **2017-09-12**. This should be considered both with printing and when comparing the last date to the current one.
Thanks,
Matthew
|
Hi @mcwhittemore |
|
Thanks @mohit2agrawal! |
No description provided.