Statically link libortools.a into binary #23
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up till now we only had a dynamically linked
libortools.so
library in mason. We changed this in this commit upstream (context) which builds both a dynamically linked as well as a statically linked library. In additionThis makes the or-tools mason package a bit bigger in size (in the hundreds of megabytes) but now we have debug binaries available. For our release node bindings we simply strip out debug symbols when linking the node binaries such that the final statically linked bindings come down to roughly ten megabytes in size.
If this works out we need to release v1.0.3 - see https://github.com/mapbox/node-or-tools#releases