Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statically link libortools.a into binary #23

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Statically link libortools.a into binary #23

merged 1 commit into from
Jun 19, 2017

Conversation

daniel-j-h
Copy link
Contributor

Up till now we only had a dynamically linked libortools.so library in mason. We changed this in this commit upstream (context) which builds both a dynamically linked as well as a statically linked library. In addition

  • these libraries do include debug symbols and
  • have their functions put into own sections so that our linker can discard what's not needed when building the node binaries

This makes the or-tools mason package a bit bigger in size (in the hundreds of megabytes) but now we have debug binaries available. For our release node bindings we simply strip out debug symbols when linking the node binaries such that the final statically linked bindings come down to roughly ten megabytes in size.


If this works out we need to release v1.0.3 - see https://github.com/mapbox/node-or-tools#releases

@daniel-j-h daniel-j-h merged commit 9b4781b into master Jun 19, 2017
@daniel-j-h daniel-j-h deleted the static-deps branch June 19, 2017 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant