Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production should not include so many packages! #327

Closed
farfromrefug opened this issue Oct 31, 2017 · 1 comment
Closed

Production should not include so many packages! #327

farfromrefug opened this issue Oct 31, 2017 · 1 comment

Comments

@farfromrefug
Copy link

if i had node-pre-gyp to my modules it has 30Mo!!!!
I am ok with that when i am building my app.
But that should not be the case in prod.
In prod the only thing you need from node-pre-gyp is find
As an example i created a fork of node-pre-gyp which i called node-pre-gyp-prod
Now in my native modules i put node-pre-gyp as a dev dependency and ``node-pre-gyp-prodas a dependency. Also when i need to require my bindings i now usenode-pre-gyp-prod```.
You can look at my fork of ```node-usb``` as an example.

This could and SHOULD be handled by node-pre-gyp. You simply need to put all the dependencies as dev dependencies.
Please make that change for everyone to profit from this!

@springmeyer
Copy link
Contributor

See #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants