Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirects when downloading are not followed #360

Closed
pimterry opened this issue Mar 28, 2018 · 2 comments
Closed

Redirects when downloading are not followed #360

pimterry opened this issue Mar 28, 2018 · 2 comments

Comments

@pimterry
Copy link

Redirects are not followed, resulting in errors like:

node-pre-gyp ERR! Tried to download(302): https://github.com/resin-io/node-ext2fs/releases/download/v1.0.1/bindings-v1.0.1-node-v57-linux-x64.tar.gz 

Here we're using https://www.npmjs.com/package/node-pre-gyp-github to store our release in github releases, and it appears there's been some github changes so this now results in a 302, which would take us to a successful download URL.

Unfortunately that redirect which would be successful is not used (and the build fails instead), because node-pre-gyp only handles status code 200:

if (res.statusCode !== 200) {

@allenluce
Copy link
Contributor

Check out #359 -- I ran into the same issue. I've submitted #361 to fix it.

@pimterry
Copy link
Author

Awesome, thanks @allenluce! I'll close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants