Have needle follow redirects #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 28, 2018
Redirect following for binary installations was broken with the switch to needle (in 9a9089b). This replaces the functionality.
allenluce
force-pushed
the
needle-follow-redirects
branch
from
a922516
to
7b631ed
Compare
pimterry
reviewed
Mar 28, 2018
lib/install.js
Outdated
| @@ -105,7 +106,10 @@ function place_binary(from,to,opts,callback) { | |||
| }); | |||
|
|
|||
| req.on('response', function(res) { | |||
| if (res.statusCode !== 200) { | |||
| if (res.statusCode === 302) { | |||
There was a problem hiding this comment.
You probably want to allow other 30x codes here too I think.
There was a problem hiding this comment.
I've changed it to check for a Location: header instead.
|
Thanks for catching this regression. Before merging this we'll need some kind of test to make sure it is actually working + does not regress again. Could you add a test? |
added 2 commits
March 28, 2018 13:02
This will handle things needle thinks are redirects without having to check a bunch of status codes.
This introduces nock as a means of mocking HTTP requests.
|
FYI, I've just now noticed the error and have been able to repro it (using Node 4 under OSX, Node 6 on my box seems to work fine). I'll be able to tackle this in a couple hours. |
|
It affects all node versions, all systems. |
allenluce
force-pushed
the
needle-follow-redirects
branch
from
be9fdeb
to
c6e5eab
Compare
So it doesn't fail on non-OSX, non-node-4 platforms.
allenluce
force-pushed
the
needle-follow-redirects
branch
from
c6e5eab
to
b2e0d08
Compare
akloboucnik
added a commit
to blockcollider/bcnode
that referenced
this pull request
Apr 5, 2018
- caused by allenluce/mmap-object#14 - which is transitively caused by mapbox/node-pre-gyp#361
|
Is there something keeping this from being merged? |
|
Thanks for this work, it is now included in |
ramijarrar
added a commit
to fractal-code/meteor-azure-server-init
that referenced
this pull request
Apr 24, 2018
Regression was fixed by mapbox/node-pre-gyp#361
hyj1991
pushed a commit
to X-Profiler/node-pre-gyp
that referenced
this pull request
Jun 16, 2023
Have needle follow redirects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirect following for binary installations broke with the switch to needle. This replaces the functionality.
Not having a redirect means (at least in my case) that pre-built binaries that are registered as part of a Github release cannot be downloaded.
This addresses #359