Allow for single-level module_path when packing #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to 0.7.1, a module_path of `./lib` would result in a package
containing files like this (using `test/app8` as an example):
lib/app8.node
The switch to tar 3 in 0.7.1 causes the same package to end up like
this:
package.json
app8.cc
binding.gyp
index.js
README.md
lib/app8.node
which causes a problem during remote binary installation:
node-pre-gyp ERR! Pre-built binaries not installable for PACKAGE@0.0.1 and node@8.3.0 (node-v57 ABI, glibc) (falling back to source compile with node-gyp)
node-pre-gyp ERR! Hit error ENOTDIR: Cannot cd into '..dirs/package/lib'
This commit fixes this problem and allows for single-level module_path
values.
|
@allenluce thank you for this. Looks like there are some minor failures (https://travis-ci.org/mapbox/node-pre-gyp/jobs/371702547#L805) when this test is run on different operating systems. How about, instead of checking actual file names, we just check the # of files added? |
But don't compare Linux to Apple.
|
I always seem to forget this bit! Let me know if the last commit will do it for you. |
This should work everywhere except AIX.
allenluce
force-pushed
the
pack-the-old-way
branch
2 times, most recently
from
ea7a374
to
68f907f
Compare
This is based on what showed up during an Appveyor run. Someone with more Win32 module building experience should verify that these are expected and correct.
allenluce
force-pushed
the
pack-the-old-way
branch
from
68f907f
to
6801a8b
Compare
mapsam
approved these changes
Apr 27, 2018
There was a problem hiding this comment.
Looks great @allanwalkerit - thank you so much! Per discussion with @springmeyer plan is to release a new version today. The retire failures have been removed in master, so we can go ahead without those.
AlCalzone
added a commit
to AlCalzone/node-aead-crypto
that referenced
this pull request
Apr 30, 2018
Next attempt at fixing the installation error. This time with merged PR mapbox/node-pre-gyp#371
allenluce
pushed a commit
to allenluce/mmap-object
that referenced
this pull request
May 1, 2018
With the merge of mapbox/node-pre-gyp#371, node-pre-gyp version 10 now works again. Also grab the new mocha, just because.
allenluce
pushed a commit
to allenluce/mmap-object
that referenced
this pull request
Jun 13, 2018
With the merge of mapbox/node-pre-gyp#371, node-pre-gyp version 10 now works again. Also grab the new mocha, just because.
hyj1991
pushed a commit
to X-Profiler/node-pre-gyp
that referenced
this pull request
Jun 16, 2023
* Allow for single-level module_path when packing
Prior to 0.7.1, a module_path of `./lib` would result in a package
containing files like this (using `test/app8` as an example):
lib/app8.node
The switch to tar 3 in 0.7.1 causes the same package to end up like
this:
package.json
app8.cc
binding.gyp
index.js
README.md
lib/app8.node
which causes a problem during remote binary installation:
node-pre-gyp ERR! Pre-built binaries not installable for PACKAGE@0.0.1 and node@8.3.0 (node-v57 ABI, glibc) (falling back to source compile with node-gyp)
node-pre-gyp ERR! Hit error ENOTDIR: Cannot cd into '..dirs/package/lib'
This commit fixes this problem and allows for single-level module_path
values.
* Compare apples to apples
But don't compare Linux to Apple.
* Use a platform-specific dynamic object extension
This should work everywhere except AIX.
* Fix Win32 file expectations
This is based on what showed up during an Appveyor run. Someone with
more Win32 module building experience should verify that these are
expected and correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to 0.7.1, a module_path of
./libwould result in a package containing files like this (usingtest/app8as an example):The switch to tar 3 in 0.7.1 causes the same package to end up like this:
which causes a problem during remote binary installation:
This commit fixes this problem and allows for single-level module_path values.
Fixes #364