Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support extracting compiled binary from local offline mirror #459

Merged
merged 1 commit into from
May 17, 2019
Merged

Support extracting compiled binary from local offline mirror #459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
58 changes: 44 additions & 14 deletions lib/install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,9 @@ function place_binary(from,to,opts,callback) {
if (err) return callback(err);
if (!req) return callback(new Error("empty req"));
var badDownload = false;
var extractCount = 0;
var hasResponse = false;
var tar = require('tar');

function afterTarball(err) {
function afterExtract(err, extractCount) {
if (err) return callback(err);
if (badDownload) return callback(new Error("bad download"));
if (extractCount === 0) {
Expand All @@ -105,11 +103,6 @@ function place_binary(from,to,opts,callback) {
callback();
}

function filter_func(entry) {
log.info('install','unpacking ' + entry.path);
extractCount++;
}

// for request compatibility
req.on('error', function(err) {
badDownload = true;
Expand Down Expand Up @@ -151,15 +144,47 @@ function place_binary(from,to,opts,callback) {
return callback(err);
}
// start unzipping and untaring
req.pipe(tar.extract({
cwd: to,
strip: 1,
onentry: filter_func
}).on('close', afterTarball).on('error', callback));
req.pipe(extract(to, afterExtract));
});
});
}

function extract_from_local(from, to, callback) {
if (!fs.existsSync(from)) {
return callback(new Error('Cannot find file ' + from));
}
log.info('Found local file to extract from ' + from);
function afterExtract(err, extractCount) {
if (err) return callback(err);
if (extractCount === 0) {
return callback(new Error('There was a fatal problem while extracting the tarball'));
}
log.info('tarball', 'done parsing tarball');
callback();
}
fs.createReadStream(from).pipe(extract(to, afterExtract));
}

function extract(to, callback) {
var extractCount = 0;
function filter_func(entry) {
log.info('install','unpacking ' + entry.path);
extractCount++;
}

function afterTarball(err) {
callback(err, extractCount);
}

var tar = require('tar');
return tar.extract({
cwd: to,
strip: 1,
onentry: filter_func
}).on('close', afterTarball).on('error', callback);
}


function do_build(gyp,argv,callback) {
var args = ['rebuild'].concat(argv);
gyp.todo.push( { name: 'build', args: args } );
Expand Down Expand Up @@ -235,7 +260,12 @@ function install(gyp, argv, callback) {
if (err) {
after_place(err);
} else {
place_binary(from,to,opts,after_place);
var fileName = from.startsWith('file://') && from.replace(/^file:\/\//, '');
if (fileName) {
extract_from_local(fileName, to, after_place);
} else {
place_binary(from,to,opts,after_place);
}
}
});
}
Expand Down