-
-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish 5.0.1 #1386
Comments
@kewde I note you released 5.0.1 16 days ago. Can this be published to npm so that we can pick up on these changes. SNYK has identified an issue with 5.0.0 which is fixed by 5.0.1 Note that the repo readme reflects the changes in 5.0.1 not those that are in 5.0.0. Hence the discrepancy we are getting identifying sqlite3 as 3.31.1 (https://nvd.nist.gov/vuln/detail/CVE-2020-11656) and not 3.32.2 as declared in the readme. Hugely appreciate your work on this. |
Any progress on this? |
We are wondering if there is any update on this |
Hi, do you have an update on this? Is there anything we can do to help? |
no issue - the 4.2.0 version of `sqlite3` that we're using is not compatible with `worker_threads` - 5.0.0 should add support this but there are other errors - 5.0.1 is released but not published (TryGhost/node-sqlite3#1386)
no issue - the 4.2.0 version of `sqlite3` that we're using is not compatible with `worker_threads` - 5.0.0 should add support this but there are other errors - 5.0.1 is released but not published (TryGhost/node-sqlite3#1386)
@kewde adding to the rest of comments above ➕ Would love to help 5.0.1 npm publish happen as well. P.S. Big thanks for all the work you've put into this project 🖤 |
Same here 👍 (Posting here to be sure to get a notification) |
Looks like this post might add some color: https://kewde.github.io/sqlite Sounds like kewde wants someone trustworthy with experience being a long-term open-source maintainer and who relies on node-sqlite3 for their business to step up and make a long-term commitment to helping maintain. Any takers? |
5.0.1 has been published on npm 🎉 |
@awjreynolds think this issue can be closed now? |
Fantastic! |
thank you! |
refs #13091 - When the job is run under Node v14 with SQLite DB the parentPort is `null` in some of the environments. The guarding code protects from the job crashing in such situation. - The most probable cause is running btrheds with `BTHREADS_BACKEND = 'child_process';` configuration for SQLite. Should be fixed once TryGhost/node-sqlite3#1386 is properly resolved
It appears you've updated and finished 5.0.1 but have not published it to npm etc.
The text was updated successfully, but these errors were encountered: