Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad comparison of c string #1347

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Fix bad comparison of c string #1347

merged 1 commit into from
Jul 2, 2020

Conversation

mtgto
Copy link
Contributor

@mtgto mtgto commented Jun 23, 2020

(While investigation of #1335) I found some bad c-string comparison.
C++ compiler already warns this bug in CI.
example https://travis-ci.org/github/mapbox/node-sqlite3/jobs/685282346#L683

IMO, this bug doesn't really seem to cause negative consequences, thanks to awesome modern C++ compiler optimization.

@kewde
Copy link
Collaborator

kewde commented Jul 2, 2020

Thanks again @mtgto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants