Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node-pre-gyp to version 0.9.0 #952

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Upgrade node-pre-gyp to version 0.9.0 #952

merged 1 commit into from
Mar 14, 2018

Conversation

SebastianSchmidt
Copy link
Contributor

Closes #950

@SebastianSchmidt SebastianSchmidt changed the title Upgrade node-pre-gyp to version 0.9.0 [Work in progress] Upgrade node-pre-gyp to version 0.9.0 Mar 14, 2018
@SebastianSchmidt SebastianSchmidt changed the title [Work in progress] Upgrade node-pre-gyp to version 0.9.0 Upgrade node-pre-gyp to version 0.9.0 Mar 14, 2018
@SebastianSchmidt
Copy link
Contributor Author

SebastianSchmidt commented Mar 14, 2018

@springmeyer The OS X NODE_VERSION="5" COVERAGE=true PUBLISHABLE=false job failed. This error has already occurred before this pull request.

build/temp.macosx-10.12-intel-2.7/_openssl.c:493:10: fatal error: 'openssl/opensslv.h' file not found
#include <openssl/opensslv.h>
         ^
1 error generated.
error: Setup script exited with error: command 'cc' failed with exit status 1
The command "if [[ ${COVERAGE} == true ]]; then if [[ $(uname -s) == 'Linux' ]]; then PYTHONUSERBASE=$(pwd)/py-local pip install --user cpp-coveralls; else PYTHONUSERBASE=$(pwd)/py-local easy_install --user cpp-coveralls; fi; fi" failed and exited with 1 during .

@springmeyer
Copy link
Contributor

Yes, that is safe to ignore/unrelated to your PR. Thanks for providing this, merging now.

@springmeyer springmeyer merged commit c4659eb into TryGhost:master Mar 14, 2018
@ronkorving
Copy link

Awesome fellas :)
Hoping to see a release on NPM soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants