Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make possible easy filter sharing #403

Open
grinapo opened this issue Oct 9, 2019 · 4 comments
Open

make possible easy filter sharing #403

grinapo opened this issue Oct 9, 2019 · 4 comments

Comments

@grinapo
Copy link

grinapo commented Oct 9, 2019

I'm submitting a feature request

Brief Description

One of the most obvious missing (or unfindable) features is filter sharing. It seems to be rather simple, either by sharing the uuid or the filter json but I don't see any real possibility to do so.

Sharing the uuid results various errors, and can't seem to find anything export or import filter json.

What is the motivation / use case for this feature?

Filter sharing with fellow editors.

Other Information / context:

Most obvious way would be to have export and import functions.

Second best could be to have a publicly available URL to see the filter by its id.

@willemarcel
Copy link
Collaborator

Hi @grinapo ! Thank you for your suggestion. I'd like to understand a bit more it...

What do you mean by sharing is allowing other users to access and see your filter results? It's possible sharing the link of your saved filter, e.g: https://osmcha.mapbox.com/filters?aoi=9687a0a0-b76d-4312-8b9c-706b53189ced

An idea I had, but is not implemented yet, was to explicitly share it with another user and list all filters shared with you on a user page.

@grinapo
Copy link
Author

grinapo commented Oct 10, 2019

There are two things I was meant:

  1. I wanted others to see my filter and its results. When I tried several forms or URL I've got various errors, but now I am guessing that the filter and the results are not necessarily visible when someone's not logged in (I have tested by copying it in another browser)
  2. It was not obvious how am I supposed to share the filter. I was guessing at various URLs and tried to copy them one by one, but this is suboptimal. I'd suggest a very specific button or link as "share this filter" or similar.

But, indeed, when I'm logged in and use the format you showed it works. Maybe that's just a documentation issue.

@willemarcel
Copy link
Collaborator

willemarcel commented Oct 10, 2019

First action items:

  • add button to share filter
  • Improve login screens to be clear to the user that some resource requires authentication

@willemarcel
Copy link
Collaborator

@grinapo I added a link button that copies the saved filter url to your clipboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants