New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSMCha shows features and tags not edited in the selected changeset #604
Comments
That’s very likely an overpass API limitation. StreetComplete is known for uploading multiple versions of an object in a very short amount of time. Overpass cannot distinguish those object versions, in case they were created at the exact same hour:minute:second, giving you incorrect results for a particular changeset. Related discussion: streetcomplete/StreetComplete#2318 (comment) |
As @mmd-osm said, it's an issue on Overpass and StreetComplete |
It is not a StreetComplete bug, as uploading multiple changesets shortly after each other is perfectly fine use of OSM API. Though it is anyway covered by #492 |
Depends a bit on your point of view. Every other editing app would merge multiple changes to the same object into a single object version upload only. SC has its reasons to work differently. The more messages I see in my log files, the more I’m disagreeing with it. |
Hmm, adding one second delay may be actually doable. Open issue on SC issue tracker once you will be sufficiently disagreeable with it. (no promising anything as I have no idea how this code works and about potential impact, but maybe it is possible to easily achieve more friendly behavior) |
I do not agree. Achavi is also based on overpass but it doesn't show this behaviour. For example, changeset #114816412: |
Let's take a look at the queries both tools are sending to the Overpass instances. First of all, you need to enable relations for Achavi, to have comparable queries: https://nrenner.github.io/achavi/?changeset=114816412&relations=true It seems that OSMCha is using an earlier start time: 12:32:58 vs. 12:33:05 in Achavi. Apart from this difference, I don't see other differences? Maybe this is reason for different results. |
This is a case of changesets overlapping by time and bbox [1] (shortened):
StreetComplete opens multiple changesets in parallel, one for each active quest. Each changeset has only one modify edit, two editing the same object [2] (shortened):
Using the times and bbox of changeset 114816402 (metadata, OSMCha) for the Overpass adiff query, it returns changes from other changesets that are within the same time range and bbox:
As the adiff query only returns the state at the given start and end time, not changes in between, version 5 of way 314892545 for this changeset is missing because of the later change in version 6. Other examplesby same user later in December (with filter listing all other changesets in edit session) [3]:
What OSMCha could do
Footnotes
|
I'm submitting a bug report
Brief Description
OSMCha shows features and tags not edited in the selected changeset.
What is the current behaviour?
For example, in changeset #114816402, only one feature has been edited but OSMCha shows two:
The other feature was edited in changeset #114816420.
Moreover, for the feature edited in the changeset OSMCha reports two tag changes, but only one was added. The other was added in changeset #114816412.
What is the expected behaviour ?
Only changes in the current changeset should be shown.
When does this occur ?
Very often, especially with changeset made with StreetComplete.
Please tell us about your environment:
Firefox 95.0 on Fedora 35/x64_64.
Firefox 95.0 on Windows 10/x64_64.
The text was updated successfully, but these errors were encountered: