add dash in utf-8 #113
Merged
add dash in utf-8 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default for TextDecoder is the format 'utf-8'. In my project I'm also using the library @auth0/auth0-spa-js, which loads the polyfill fast-text-encoding for TextDecoder. This polyfilled version will throw an error if it gets passed 'utf8'. This causes my app to crash on Edge. alternatives: - remove the argument, it'll default to utf-8. - wrap the initializer in a try/catch
|
Travis seems stuck for some reason — I'll wait a few hours for it to hopefully pick this up before I can merge and do a patch release. |
|
No problem, I've pinned mapboxgl to <1.5 for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default for TextDecoder is the format 'utf-8'. In my project I'm also using the library @auth0/auth0-spa-js, which loads the polyfill fast-text-encoding for TextDecoder. This polyfilled version will throw an error if it gets passed 'utf8'. This causes my app to crash on Edge.
alternatives: