Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came to the conclusion that the benchmark in
bench/bench.js
doesn’t really make a lot of sense because V8 is extremely good at optimizing stuff that does the same thing over and over.So I created a much more representative benchmark that downloads (and caches) 439 sample tiles from Mapbox Streets and runs decoding/encoding on them. Here’s a sample result:
I ran it on all commits between v2.0.1 and master and actually the most impactful change is the defaults PR. This is fine though — e.g. specifically for VT, you can optimize manually by definding a defaults object and then doing
Object.create(defaults)
. This probably doesn’t make sense for the compiler to do though — the performance is more than great as it is.cc @kjvalencik