Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: 🎨 option to set diff draw color. #36

Closed
cramatt opened this issue Feb 24, 2018 · 0 comments · Fixed by #61
Closed

feature request: 🎨 option to set diff draw color. #36

cramatt opened this issue Feb 24, 2018 · 0 comments · Fixed by #61

Comments

@cramatt
Copy link

cramatt commented Feb 24, 2018

It seems like a useful feature to provide the option to set the color for the image diff. For example in my project we are comparing red screens... so red is difficult to distinguish.

The function which uses to color is https://github.com/mapbox/pixelmatch/blob/master/index.js#L147-L152.

has anyone approached this feature before? Do you have strong opinions on how it should be done. I'm willing to take on a PR to help!

@cramatt cramatt changed the title feature request: option to set color used to draw diff image feature request: 🎨option to set color used to draw diff image Feb 24, 2018
@cramatt cramatt changed the title feature request: 🎨option to set color used to draw diff image feature request: 🎨 option to set color used to draw diff image Feb 24, 2018
@cramatt cramatt changed the title feature request: 🎨 option to set color used to draw diff image feature request: 🎨 option to set diff draw color. Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants