Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21
Instead of indexing and returning individual segments, we index the full road and return the index of the matching segment.
We avoid creating many segment objects in memory, and reduce the size of the index, at the cost of having larger bounding boxes in the index - thus potentially more candidates to check when matching a point.
The benchmark runs on average ~20% slower, although I suspect the effect would be less obvious on real datasets with larger indices.
Note that this creates a breaking change in the API, since we're not returning segments anymore.