Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flipping the sense of fillnodata's mask arg #281

Closed
sgillies opened this issue Feb 27, 2015 · 0 comments
Closed

Flipping the sense of fillnodata's mask arg #281

sgillies opened this issue Feb 27, 2015 · 0 comments
Milestone

Comments

@sgillies
Copy link
Member

Looking more deeply into fillnodata(), I'd like to flip the sense of the mask to match what we get when we read a masked array: True for nodata pixels. Doing so makes usage easier, like this:

arr = dataset.read(1, masked=True)
filled = fillnodata(arr.data, arr.mask)

whereas right now you have to pass ~arr.mask.

Even easier would be if fillnodata() checks the input image for a mask:

arr = dataset.read(1, masked=True)
filled = fillnodata(arr) # arr.mask used by default if available
@sgillies sgillies changed the title Flipping the sense of fillnodata Flipping the sense of fillnodata's mask arg Feb 27, 2015
@sgillies sgillies added the bug label Feb 27, 2015
@sgillies sgillies added this to the 0.19 milestone Feb 27, 2015
@sgillies sgillies removed the bug label Feb 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant