Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access requireNativeComponent through public module interface #54

Merged
merged 1 commit into from Jul 1, 2015

Conversation

brentvatne
Copy link
Collaborator

As per facebook/react-native#1821 - with 0.7.0+, requiring of any React Native internal modules will need to go through the public interface 馃槃 馃憤

@bsudekum
Copy link

bsudekum commented Jul 1, 2015

@brentvatne great, are there any changes you see that need to happen for 0.7.0+? Working on a release for 0.6.0 now but could potential make a release for both.

@brentvatne
Copy link
Collaborator Author

Nothing else stands out to me! This fix will work on both 0.6 and 0.7 馃槃

bsudekum pushed a commit that referenced this pull request Jul 1, 2015
Access requireNativeComponent through public module interface
@bsudekum bsudekum merged commit b414e28 into master Jul 1, 2015
@bsudekum bsudekum deleted the fix-require-for-07 branch July 1, 2015 16:06
emerson233 pushed a commit to studyroz/react-native-mapbox-gl that referenced this pull request Aug 9, 2019
related to [nitaliano#54](https://github.com/react-native-mapbox-gl/maps/issues/54): I spent to much time trying to fix a bug on a PointAnnotation... if it was clearer, it would have been much better !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants