Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pxm-alpha #14

Merged
merged 7 commits into from
Aug 26, 2016
Merged

Migrate pxm-alpha #14

merged 7 commits into from
Aug 26, 2016

Conversation

virginiayung
Copy link
Collaborator

@virginiayung virginiayung commented Aug 23, 2016

Resolves #13
Refs https://github.com/mapbox/pxm/issues/622.

  • Migrate pxm-alpha to alpha_lossy and alpha_non_lossy modules
  • Refactor alpha_lossy and alpha_non_lossy modules
  • Add alpha_lossy and alpha_non_lossy command to cli.py
  • Tests:
    • property-based
    • test_cli
    • test with fixtures (Refer to example of testing with flex-compare in rio-toa)
  • Update docstrings + README
  • Clean up, Rebase
  • Review 馃憖
  • Merge PR Migrate pxm-alpha聽#14 into master
  • Update version to 0.3.0

cc @jacquestardie

@jqtrde
Copy link
Contributor

jqtrde commented Aug 23, 2016

Current coverage is 99.50% (diff: 100%)

Merging #14 into master will increase coverage by 0.73%

@@             master        #14   diff @@
==========================================
  Files             6          7     +1   
  Lines           162        202    +40   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            160        201    +41   
+ Misses            2          1     -1   
  Partials          0          0          

Powered by Codecov. Last update 6830b6d...f28283d

@virginiayung virginiayung mentioned this pull request Aug 23, 2016
12 tasks
@@ -0,0 +1,140 @@
import numpy as np
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's axe all of this - a main impetus for this repo is to cleanup our past mistakes, this wasn't well tested or robust, and I feel that starting from scratch is a better option

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in commit b3cf7a2

@virginiayung virginiayung merged commit 911e6c2 into master Aug 26, 2016
@virginiayung virginiayung deleted the alpha-alpha branch August 26, 2016 23:04
This was referenced Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port pxm-alpha
3 participants