Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting units and description #14

Closed
perrygeo opened this issue Aug 24, 2016 · 1 comment
Closed

Support setting units and description #14

perrygeo opened this issue Aug 24, 2016 · 1 comment
Assignees
Milestone

Comments

@perrygeo
Copy link
Contributor

perrygeo commented Aug 24, 2016

Rasterio 1.0 comes with some methods to set metadata for band-level units and descriptions. The methods are only available on a dataset writer object. In the case of riomucho, the code calling it never has access to that object. All it sees is:

with riomucho.RioMucho(..., dst_path, ...) as rm:
    rm.run(jobs)

What's the best solution? Do we expose these methods on the rio mucho object? Or is there a more generalizable way for us to reach into the dataset object methods from a rio-mucho caller?

See mapbox/rio-toa#23

thoughts @dnomadb @sgillies ?

@sgillies
Copy link
Contributor

Almost 2 years later: I propose that we keep riomucho out of the metadata business. To do that, we need to let the constructor accept open dataset objects as well as paths. Yes?

@sgillies sgillies added this to the 1.0 milestone Jul 11, 2018
sgillies pushed a commit that referenced this issue Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants