Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Modernize build2 #7

Closed
wants to merge 2 commits into from
Closed

Conversation

springmeyer
Copy link
Contributor

@springmeyer springmeyer commented Apr 12, 2017

Combo of #5 and #6.

@ghoshkaj and @chaupow - This brings in your working changes + node-cpp-skel best practices and tools. Per voice, in the future node-cpp-skel will provide cmake based build, but for now this is using gyp. I propose merging this to master, then working from this as a base.

@springmeyer springmeyer changed the base branch from master to congestion-cpp-hashmap April 12, 2017 01:46
@springmeyer
Copy link
Contributor Author

Rebased this branch against congestion-cpp-hashmap. New plan is to merge this into congestion-cpp-hashmap and #6 into master. This will get master testing on travis without congestion related changes. And get the congestion work benefitting from the build modernization.

@codecov-io
Copy link

codecov-io commented Apr 12, 2017

Codecov Report

❗ No coverage uploaded for pull request base (congestion-cpp-hashmap@cc9134b). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##             congestion-cpp-hashmap       #7   +/-   ##
=========================================================
  Coverage                          ?   60.92%           
=========================================================
  Files                             ?        7           
  Lines                             ?      325           
  Branches                          ?        0           
=========================================================
  Hits                              ?      198           
  Misses                            ?      127           
  Partials                          ?        0
Impacted Files Coverage Δ
src/nodejs_bindings.cpp 46.37% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc9134b...0cbe031. Read the comment docs.

@springmeyer
Copy link
Contributor Author

Closing. This work is now over at #8

@springmeyer springmeyer deleted the modernize-build2 branch April 12, 2017 02:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants