Add universal preloader function #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelmaron
reviewed
Jul 18, 2022
| @@ -334,7 +376,18 @@ | |||
| }) | |||
| .onStepEnter(async response => { | |||
| var chapter = config.chapters.find(chap => chap.id === response.element.id); | |||
| var chapterid = chapter.id; | |||
There was a problem hiding this comment.
where is chapterid used?
mikelmaron
reviewed
Jul 18, 2022
|
|
||
| // Code for preloader, app will not show an active map until underlying tilesets are fully loaded | ||
|
|
||
| if (chapter.id != null) { |
There was a problem hiding this comment.
whether or not chapter.id is null, opacity is set to 0
mikelmaron
reviewed
Jul 18, 2022
| @@ -457,6 +510,18 @@ | |||
| insetMap.getSource('boundsSource').setData(bounds); | |||
| } | |||
|
|
|||
| function customizeChapters(chap) { | |||
There was a problem hiding this comment.
this function is never called?
|
@pkfranz some questions in comments. also why is config.js.template renamed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mikelmaron This should seamlessly work on any project, regardless of
chapter.idnaming conventions.Possible feature add: Adding it as an boolean variable in the array vs. always on?