Make implicit API expectation explicit #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was bitten by issue mapbox#42 when trying to implement a tilelive TileSource that used vector tiles, which by their nature are sparse. (My backend would faithfully emit error messages for missing tiles, but with a different wording which med tilelive crash out rather than just skip the tile.) Until the actual issue is resolved (which would mean rewriting all tilelive implementations, I guess) it should be made an explicit part or the API doc.
robpvn
changed the title
|
Ignore the fact that I made a rather silly typo in the commit title. 👌 |
|
👍 thanks @robpvn ! Merging |
tmcw
added a commit
that referenced
this pull request
Aug 7, 2015
Make implicit API expectation explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was bitten by issue #42 when trying to implement a tilelive TileSource that used vector tiles, which by their nature are sparse. (My backend would faithfully emit error messages for missing tiles, but with a different wording which made tilelive crash out rather than just skip the tile.) Until the actual issue is resolved (which would mean bumping the API version and rewriting all tilelive implementations, I guess) it should be made an explicit part or the API doc.