Handle null uri.pathname bug #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,7 +76,8 @@ tilelive.load = function(uri, callback) { | |||
|
|
|||
| if (typeof uri === 'string') { | |||
| uri = url.parse(uri, true); | |||
| uri.pathname = qs.unescape(uri.pathname); | |||
| if (uri.pathname) | |||
There was a problem hiding this comment.
Please use brackets for multiline if statements.
nyurik
force-pushed
the
master
branch
2 times, most recently
from
9d54027
to
676b098
Compare
|
@tmcw thx, didn't see your comment, fixed. |
Sometimes modules do not require a full path, and can use shorter version, e.g. overzoom://?source=blah which results in the null pathname, which fails in the unescape.
|
@tmcw is there anything preventing this PR? thx! |
|
Looks like this keeps failing one test on node 0.12.x. |
|
@rclark I just installed node v0.12.13 using nvm, did npm install and npm test, and it all passes on my machine. Could this be a bug in travis? |
|
Thanks for investigating -- I reran the travis test and it passed, so some other issue. My only other request would be a test that asserts a URI without a path parses successfully, to protect against any future regression. |
|
@rclark added. Also, in the process i discovered that this bug only happens for node 0.10. In node 0.12, the patch is no longer relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes modules do not require a full path,
and can use shorter version, e.g. overzoom://?source=blah
which results in the null pathname, which fails in the unescape.