Implement minzoom and maxzoom options for stream-list #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @StevenLooman -- appreciate the PR, but the intention of the list stream is that you provide exactly the tiles that you want to have copied. I'd rather not implement any filtering that would obscure that contract. |
|
Fair enough. Then an error should be raised when both the list and the min/maxzoom options are used. The user expects a filtering mechanism (the options are given), but is ignored when a list is provided. The user is misguided in this case. |
|
Agree -- that sounds like a good pre-check to get into tilelive-copy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement honoring the parameters
minzoomandmaxzoomintilelive-copywhen using a list as an input stream. This allows filtering intilelive-copy, and thus saves work of filtering the input list by hand.