Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against node v0.10, v4, and v6 #196

Closed
wants to merge 1 commit into from
Closed

Conversation

springmeyer
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Apr 14, 2017

Coverage Status

Coverage remained the same at 97.685% when pulling ccb0568 on node-v4-6-test into d9a0bdc on master.

@springmeyer
Copy link
Contributor Author

Hmm, failing with:

not ok 230 round-tripped mbtiles are approx. the same size
  ---
    operator: ok
    expected: true
    actual:   false
    at: Put.makeAssertions (/home/travis/build/mapbox/tilelive/test/stream-deserialize.test.js:189:11)
  ...

@springmeyer
Copy link
Contributor Author

Looks like this has been failing for a while. I notice as far back as #188

@springmeyer
Copy link
Contributor Author

Don't have time to look into this test failure now, punting on this. Anyone please feel free to pick this up.

@mapsam
Copy link
Member

mapsam commented Apr 14, 2017

@springmeyer I put this together yesterday in a separate PR: #195 - I didn't include node v0.10 though.

@springmeyer
Copy link
Contributor Author

Thanks @mapsam - sorry for missing your PR! Closing this one.

@springmeyer springmeyer deleted the node-v4-6-test branch April 14, 2017 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants