Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyramid smarterskip #84

Merged
merged 6 commits into from
Sep 15, 2015
Merged

Pyramid smarterskip #84

merged 6 commits into from
Sep 15, 2015

Conversation

yhahn
Copy link
Member

@yhahn yhahn commented Aug 12, 2014

Implements #83. Needs some real world testing before merge.

@GretaCB
Copy link
Contributor

GretaCB commented Sep 18, 2014

@yhahn is anything blocking this?

@yhahn
Copy link
Member Author

yhahn commented Sep 18, 2014

Yeah, just real world testing. Do you want to point a branch of mapbox-studio at it and give it some testing?

@GretaCB
Copy link
Contributor

GretaCB commented Sep 18, 2014

👍 perf. I'll give this a whirl tonight. I have a perfect source to test it with.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) when pulling 5f97ca5 on pyramid-smarterskip into 580d44f on master.

@GretaCB
Copy link
Contributor

GretaCB commented Sep 19, 2014

Tried out in staging, getting a variety of errors (vector_layers array error, unknown format error, or just not uploading from studio). Going to punt for now while I close some things out today.

Conflicts:
	lib/stream-pyramid.js
	test/stream-pyramid.test.js
@GretaCB
Copy link
Contributor

GretaCB commented Sep 15, 2015

yhahn added a commit that referenced this pull request Sep 15, 2015
@yhahn yhahn merged commit e19fce2 into master Sep 15, 2015
@yhahn yhahn deleted the pyramid-smarterskip branch September 15, 2015 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants